netdev - Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y6L6G3bPVony+B5X@shell.armlinux.org.uk>
Date:   Wed, 21 Dec 2022 12:20:43 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Liang Xu <lxu@...linear.com>
Cc:     Michael Walle <michael@...le.cc>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Ismail, Mohammad Athari" <mohammad.athari.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Thomas Mohren <tmohren@...linear.com>
Subject: Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

Hi,

On Wed, Dec 14, 2022 at 09:16:46AM +0000, Liang Xu wrote:
> From: Michael Walle <michael@...le.cc>
> Sent: Wednesday, December 14, 2022 5:00 PM
> Subject: Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function
> 
> This email was sent from outside of MaxLinear.
> 
> 
> Subject is missing the correct target, "net" in this case.
> 
> > GPY need 3 seconds to switch out of loopback mode.
> 
> What does that mean, what goes wrong with the current 100ms?
> Could you elaborate a bit more and update the commit message
> and the comment? Is this true for any GPY PHY supported by
> this driver?
> 
> The internal state machine need almost 3s to fully restore to original state when leaving the loopback mode.
> This is true for all models supported by this driver.
> I will update the commit message and fix the target.
> Thank you.

When you state that it takes almost 3 seconds to fully restore the
state, what are you basing that upon - what are you using to determine
that the state has been fully restored?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!