lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Dec 2022 05:23:12 +0000 From: Liang Xu <lxu@...linear.com> To: "Russell King (Oracle)" <linux@...linux.org.uk> CC: "andrew@...n.ch" <andrew@...n.ch>, "hkallweit1@...il.com" <hkallweit1@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>, Hauke Mehrtens <hmehrtens@...linear.com>, Thomas Mohren <tmohren@...linear.com>, "Ismail, Mohammad Athari" <mohammad.athari.ismail@...el.com>, "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, Samuels Xu <samuelsdream@...mail.com> Subject: Re: [PATCH net v2] net: phy: mxl-gpy: fix delay time required by loopback disable function Thanks & Regards, Xu Liang > ________________________________________ > From: Russell King <linux@...linux.org.uk> on behalf of Russell King (Oracle) <linux@...linux.org.uk> > Sent: Wednesday, December 21, 2022 8:21 PM > To: Liang Xu > Cc: andrew@...n.ch; hkallweit1@...il.com; netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org; Hauke Mehrtens; Thomas Mohren; Ismail, Mohammad Athari; edumazet@...gle.com; pabeni@...hat.com > Subject: Re: [PATCH net v2] net: phy: mxl-gpy: fix delay time required by loopback disable function > > This email was sent from outside of MaxLinear. > > Hi, > > On Wed, Dec 21, 2022 at 05:43:58PM +0800, Xu Liang wrote: > > GPY2xx devices need 3 seconds to fully switch out of loopback mode > > before it can safely re-enter loopback mode. > > Would it be better to record the time that loopback mode is exited, > and then delay an attempt to re-enter loopback mode if it's less than > three seconds since we exited? Loopback is usually used in self-test or debugging. So I just made a simple delay to avoid complexity of time recording. Please let me know if you think it's worth to change, then I will update the patch. > > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/<https://www.armlinux.org.uk/developer/patches> > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! >
Powered by blists - more mailing lists