netdev - Re: [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y1qikre3.fsf@miraculix.mork.no>
Date:   Wed, 04 Jan 2023 20:53:56 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Matthew Garrett <mjg59@...f.ucam.org>
Cc:     johan@...nel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, Matthew Garrett <mgarrett@...ora.tech>
Subject: Re: [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207
 configuration

Matthew Garrett <mjg59@...f.ucam.org> writes:

> The Orbic Speed RC400L presents as a generic MDM9207 device that supports
> multiple configurations with different USB IDs. One exposes a QMI interface.
> Add the ID for that.
>
> Signed-off-by: Matthew Garrett <mgarrett@...ora.tech>
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index a808d718c012..bf05b7feacc0 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1223,6 +1223,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x05c6, 0x90b2, 3)},    /* ublox R410M */
>  	{QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
>  	{QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
> +	{QMI_FIXED_INTF(0x05c6, 0xf601, 5)},
>  	{QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)},	/* YUGA CLM920-NC5 */
>  	{QMI_FIXED_INTF(0x0846, 0x68a2, 8)},
>  	{QMI_FIXED_INTF(0x0846, 0x68d3, 8)},	/* Netgear Aircard 779S */


Looks good to me, but checkpatch warns about

 WARNING: From:/Signed-off-by: email address mismatch: 'From: Matthew Garrett <mjg59@...f.ucam.org>' != 'Signed-off-by: Matthew Garrett <mgarrett@...ora.tech>'

which you might want to consider, unless this was intentional for some
reason?  In any case:

Acked-by: Bjørn Mork <bjorn@...k.no>