netdev - Re: [PATCH V2 1/3] USB: serial: option: Add generic MDM9207 configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8A1OCqtqdSVQPf9@hovoldconsulting.com>
Date:   Thu, 12 Jan 2023 17:28:40 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Matthew Garrett <mjg59@...f.ucam.org>
Cc:     bjorn@...k.no, netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        Matthew Garrett <mgarrett@...ora.tech>
Subject: Re: [PATCH V2 1/3] USB: serial: option: Add generic MDM9207
 configurations

On Mon, Dec 26, 2022 at 03:47:49PM -0800, Matthew Garrett wrote:
> The Orbic Speed RC400L presents as a generic MDM9207 device that supports
> multiple configurations. Add support for the two that expose a set of serial
> ports.

Would you mind including the output of usb-devices for this device here
for completeness?

> Signed-off-by: Matthew Garrett <mgarrett@...ora.tech>
> ---
>  drivers/usb/serial/option.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index dee79c7d82d5..5025810db8c9 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1119,6 +1119,12 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
>  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
>  	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
> +	/* Qualcomm MDM9207 - 0: DIAG, 1: modem, 2: AT, 3: NMEA, 4: adb, 5: QMI */

We typically just include the port layout in the commit message (along
with usb-devices output). Then you can move the device comment to the
end of the USB_DEVICE() line (cf. ONYX 3G device above).

> +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf601),
> +	  .driver_info = RSVD(4) | RSVD(5) },
> +	/* Qualcomm MDM9207 - 0,1: RNDIS, 2: DIAG, 3: modem, 4: AT, 5: NMEA, 6: adb */
> +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf622),
> +	  .driver_info = RSVD(0) | RSVD(1) | RSVD(6) },
>  	/* Quectel products using Qualcomm vendor ID */
>  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
>  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Johan