netdev - Re: [PATCH V2 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8A1TzUO9JB5c+lQ@hovoldconsulting.com>
Date:   Thu, 12 Jan 2023 17:29:03 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Matthew Garrett <mjg59@...f.ucam.org>
Cc:     bjorn@...k.no, netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH V2 3/3] USB: serial: option: Add Novatel MiFi 8800L diag
 endpoint

On Mon, Dec 26, 2022 at 03:47:51PM -0800, Matthew Garrett wrote:
> The Novatel MiFi 8800L can be configured into exposing additional
> endpoints by sending four bytes of 0s to the HID endpoint it exposes by
> default. One of the additional exposed endpoints is a Qualcomm DIAG protocol
> interface. Add the information for that in order to allow it to be used.

Could you include usb-devices output here too?

> Signed-off-by: Matthew Garrett <mjg59@...f.ucam.org>
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 5025810db8c9..40a4ccb888f9 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -161,6 +161,7 @@ static void option_instat_callback(struct urb *urb);
>  #define NOVATELWIRELESS_PRODUCT_U620L		0x9022
>  #define NOVATELWIRELESS_PRODUCT_G2		0xA010
>  #define NOVATELWIRELESS_PRODUCT_MC551		0xB001
> +#define NOVATELWIRELESS_PRODUCT_8800L		0xB023
>  
>  #define UBLOX_VENDOR_ID				0x1546
>  
> @@ -1055,6 +1056,7 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_8800L, 0xff, 0xff, 0xff) },
>  
>  	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) },
>  	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) },

Johan