netdev - RE: [Intel-wired-lan] [PATCH net v2] ixgbe: fix pci device refcount leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2023 05:00:27 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "stephend@...icom-usa.com" <stephend@...icom-usa.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2] ixgbe: fix pci device refcount
 leak



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Yang Yingliang
> Sent: Tuesday, November 29, 2022 7:28 AM
> To: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
> Cc: andrew@...n.ch; f.fainelli@...il.com; stephend@...icom-usa.com;
> edumazet@...gle.com; jeffrey.t.kirsher@...el.com; kuba@...nel.org;
> pabeni@...hat.com; davem@...emloft.net
> Subject: [Intel-wired-lan] [PATCH net v2] ixgbe: fix pci device refcount leak
> 
> As the comment of pci_get_domain_bus_and_slot() says, it returns a PCI
> device with refcount incremented, when finish using it, the caller must
> decrement the reference count by calling pci_dev_put().
> 
> In ixgbe_get_first_secondary_devfn() and ixgbe_x550em_a_has_mii(),
> pci_dev_put() is called to avoid leak.
> 
> Fixes: 8fa10ef01260 ("ixgbe: register a mdiobus")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> v1 -> v2:
>   Introduce a local variable, and put pci_dev_put() after value checks.
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)