netdev - RE: [Intel-wired-lan] [PATCH net] ice: Fix potential memory leak in ice_gnss_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2023 05:15:37 +0000
From:   "Stany V, Vasanth" <vasanth.stany.v@...el.com>
To:     Yuan Can <yuancan@...wei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net] ice: Fix potential memory leak in
 ice_gnss_tty_write()

> -----Original Message-----
> From: Intel-wired-lan <mailto:intel-wired-lan-bounces@...osl.org> On Behalf Of Yuan Can
> Sent: Wednesday, December 7, 2022 12:55 AM
> To: Brandeburg, Jesse <mailto:jesse.brandeburg@...el.com>; Nguyen, Anthony L <mailto:anthony.l.nguyen@...el.com>; mailto:davem@...emloft.net; mailto:edumazet@...gle.com; mailto:kuba@...nel.org; mailto:pabeni@...hat.com; Kolacinski, Karol <mailto:karol.kolacinski@...el.com>; mailto:intel-wired-lan@...ts.osuosl.org; mailto:netdev@...r.kernel.org
> Cc: mailto:yuancan@...wei.com
> Subject: [Intel-wired-lan] [PATCH net] ice: Fix potential memory leak in ice_gnss_tty_write()
>
> The ice_gnss_tty_write() return directly if the write_buf alloc failed, leaking the cmd_buf.
>
> Fix by free cmd_buf if write_buf alloc failed.
>
> Fixes: d6b98c8d242a ("ice: add write functionality for GNSS TTY")
> Signed-off-by: Yuan Can <mailto:yuancan@...wei.com>
> ---
> drivers/net/ethernet/intel/ice/ice_gnss.c | 1 +
> 1 file changed, 1 insertion(+)
Tested-by:  Vasanth Stany < mailto:vasanth.stany.v@...el.com >