netdev - Re: [PATCH net-next 9/9] netdevsim: move devlink registration under the instance lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7hC/FYhXz+OlM4l@nanopsycho>
Date:   Fri, 6 Jan 2023 16:49:16 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jacob.e.keller@...el.com
Subject: Re: [PATCH net-next 9/9] netdevsim: move devlink registration under
 the instance lock

Fri, Jan 06, 2023 at 07:34:02AM CET, kuba@...nel.org wrote:
>To prevent races with netdev code accessing free devlink instances
>move the registration under the devlink instance lock.
>Core now waits for the instance to be registered before accessing it.

This sentense sounds a bit confusing to me. "to be registered" does not
sound correct.

"Core now waits for the instance lock to be unlocked before executing
 access the instance" perhaps would be more accurate?


>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

One way or another. Code looks fine:
Reviewed-by: Jiri Pirko <jiri@...dia.com>