netdev - Re: [PATCH net-next 0/9] devlink: remove the wait-for-references on unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7hDGnDcjVKDSuHV@nanopsycho>
Date:   Fri, 6 Jan 2023 16:49:46 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jacob.e.keller@...el.com
Subject: Re: [PATCH net-next 0/9] devlink: remove the wait-for-references on
 unregister

Fri, Jan 06, 2023 at 07:33:53AM CET, kuba@...nel.org wrote:
>Move the registration and unregistration of the devlink instances
>under their instance locks. Don't perform the netdev-style wait
>for all references when unregistering the instance.
>
>Instead the devlink instance refcount will only ensure that
>the memory of the instance is not freed. All places which acquire
>access to devlink instances via a reference must check that the
>instance is still registered under the instance lock.
>
>This fixes the problem of the netdev code accessing devlink
>instances before they are registered.

Nice work. Thanks!