netdev - Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler for get rss (-x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230109111340.73567a60@kernel.org>
Date:   Mon, 9 Jan 2023 11:13:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler for
 get rss (-x)

On Mon, 9 Jan 2023 18:07:45 +0000 Mogilappagari, Sudheer wrote:
> > > Are you suggesting we need to use ioctl for fetching ring info to
> > > avoid mix-up. Is there alternative way to do it ?  
> > 
> > No no, look how the strings for hfunc names are fetched - they are
> > fetched over a different socket, right?  
> 
> global_stringset is using nlctx->ethnl2_socket. Are you suggesting use
> of it for fetching channels info too ? 
> 
> ret = netlink_init_ethnl2_socket(nlctx);
> ...
> hash_funcs = global_stringset(ETH_SS_RSS_HASH_FUNCS, nlctx->ethnl2_socket);

Yessir.