netdev - Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler for get rss (-x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2023 21:10:29 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler for get
 rss (-x)

On Mon, Jan 09, 2023 at 06:07:45PM +0000, Mogilappagari, Sudheer wrote:
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Friday, January 6, 2023 1:42 PM
> > To: Mogilappagari, Sudheer <sudheer.mogilappagari@...el.com>
> > Cc: netdev@...r.kernel.org; mkubecek@...e.cz; andrew@...n.ch;
> > Samudrala, Sridhar <sridhar.samudrala@...el.com>; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>
> > Subject: Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler
> > for get rss (-x)
[...]
> > No no, look how the strings for hfunc names are fetched - they are
> > fetched over a different socket, right?
> 
> global_stringset is using nlctx->ethnl2_socket. Are you suggesting use
> of it for fetching channels info too ? 
> 
> ret = netlink_init_ethnl2_socket(nlctx);
> ...
> hash_funcs = global_stringset(ETH_SS_RSS_HASH_FUNCS, nlctx->ethnl2_socket);

The purpose of the second socket is to allow sending another request
while we are still processing the data from the main request so that we
cannot reuse the primary socket.

In this case, if we do not support dumps (and do not intend to), we
could technically send both request through the same socket (one after
the other) but I think it would be easier to use ethnl2_socket for the
auxiliary request anyway.

Michal