netdev - Re: [patch net-next v2 1/9] devlink: remove devlink features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7vTUqyI/LdMNPdL@nanopsycho>
Date:   Mon, 9 Jan 2023 09:41:54 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Ido Schimmel <idosch@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, michael.chan@...adcom.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        tariqt@...dia.com, saeedm@...dia.com, leon@...nel.org,
        petrm@...dia.com, mailhol.vincent@...adoo.fr,
        jacob.e.keller@...el.com, gal@...dia.com
Subject: Re: [patch net-next v2 1/9] devlink: remove devlink features

Sun, Jan 08, 2023 at 04:32:12PM CET, idosch@...dia.com wrote:
>On Sat, Jan 07, 2023 at 11:11:42AM +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> Devlink features were introduced to disallow devlink reload calls of
>> userspace before the devlink was fully initialized. The reason for this
>> workaround was the fact that devlink reload was originally called
>> without devlink instance lock held.
>> 
>> However, with recent changes that converted devlink reload to be
>> performed under devlink instance lock, this is redundant so remove
>> devlink features entirely.
>> 
>> Note that mlx5 used this to enable devlink reload conditionally only
>> when device didn't act as multi port slave. Move the multi port check
>> into mlx5_devlink_reload_down() callback alongside with the other
>> checks preventing the device from reload in certain states.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...dia.com>
>> ---
>>  .../net/ethernet/broadcom/bnxt/bnxt_devlink.c |  1 -
>>  .../hisilicon/hns3/hns3pf/hclge_devlink.c     |  1 -
>>  .../hisilicon/hns3/hns3vf/hclgevf_devlink.c   |  1 -
>>  drivers/net/ethernet/intel/ice/ice_devlink.c  |  1 -
>>  drivers/net/ethernet/mellanox/mlx4/main.c     |  1 -
>>  .../net/ethernet/mellanox/mlx5/core/devlink.c |  9 +++++----
>>  drivers/net/ethernet/mellanox/mlxsw/core.c    |  1 -
>>  drivers/net/netdevsim/dev.c                   |  1 -
>>  net/devlink/core.c                            | 19 -------------------
>>  net/devlink/devl_internal.h                   |  1 -
>>  net/devlink/leftover.c                        |  3 ---
>>  11 files changed, 5 insertions(+), 34 deletions(-)
>
>devlink_set_features() needs to be removed from include/net/devlink.h as
>well

Missed this. Fixed.