netdev - Re: [patch net-next v2 3/9] devlink: remove linecard reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7vTaOHx+/AHZepR@nanopsycho>
Date:   Mon, 9 Jan 2023 09:42:16 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Ido Schimmel <idosch@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, michael.chan@...adcom.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        tariqt@...dia.com, saeedm@...dia.com, leon@...nel.org,
        petrm@...dia.com, mailhol.vincent@...adoo.fr,
        jacob.e.keller@...el.com, gal@...dia.com
Subject: Re: [patch net-next v2 3/9] devlink: remove linecard reference
 counting

Sun, Jan 08, 2023 at 04:50:36PM CET, idosch@...dia.com wrote:
>On Sat, Jan 07, 2023 at 11:11:44AM +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> As long as the linecard live time is protected by devlink instance
>
>s/live/life/
>
>> lock, the reference counting is no longer needed. Remove it.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...dia.com>
>> ---
>>  net/devlink/leftover.c | 14 ++------------
>>  net/devlink/netlink.c  |  5 -----
>>  2 files changed, 2 insertions(+), 17 deletions(-)
>
>devlink_linecard_put() needs to be removed from
>net/devlink/devl_internal.h

Missed this. Fixed.