lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y70/k75sqWxVL3hB@hera> Date: Tue, 10 Jan 2023 12:36:03 +0200 From: Ilias Apalodimas <ilias.apalodimas@...aro.org> To: "Matthew Wilcox (Oracle)" <willy@...radead.org> Cc: Jesper Dangaard Brouer <hawk@...nel.org>, netdev@...r.kernel.org, linux-mm@...ck.org, Shakeel Butt <shakeelb@...gle.com> Subject: Re: [PATCH v2 10/24] page_pool: Convert page_pool_put_defragged_page() to netmem On Thu, Jan 05, 2023 at 09:46:17PM +0000, Matthew Wilcox (Oracle) wrote: > Also convert page_pool_is_last_frag(), page_pool_put_page(), > page_pool_recycle_in_ring() and use netmem in page_pool_put_page_bulk(). > [...] > - if (!page_pool_is_last_frag(pool, page)) > + if (!page_pool_is_last_frag(pool, nmem)) > return; > > - page_pool_put_defragged_page(pool, page, dma_sync_size, allow_direct); > + page_pool_put_defragged_netmem(pool, nmem, dma_sync_size, allow_direct); > #endif > } > nit again, but can we add a comment that this is planned for removal once we convert teh remaining drivers? > +static inline void page_pool_put_page(struct page_pool *pool, > + struct page *page, > + unsigned int dma_sync_size, > + bool allow_direct) > +{ > + page_pool_put_netmem(pool, page_netmem(page), dma_sync_size, > + allow_direct); > +} > + [...] Regards /Ilias
Powered by blists - more mailing lists