lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y71ADsqT13215XX0@hera> Date: Tue, 10 Jan 2023 12:38:06 +0200 From: Ilias Apalodimas <ilias.apalodimas@...aro.org> To: "Matthew Wilcox (Oracle)" <willy@...radead.org> Cc: Jesper Dangaard Brouer <hawk@...nel.org>, netdev@...r.kernel.org, linux-mm@...ck.org, Shakeel Butt <shakeelb@...gle.com> Subject: Re: [PATCH v2 11/24] page_pool: Convert page_pool_empty_ring() to use netmem On Thu, Jan 05, 2023 at 09:46:18PM +0000, Matthew Wilcox (Oracle) wrote: > Retrieve a netmem from the ptr_ring instead of a page. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org> > --- > net/core/page_pool.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index e727a74504c2..0212244e07e7 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -755,16 +755,16 @@ EXPORT_SYMBOL(page_pool_alloc_frag); > > static void page_pool_empty_ring(struct page_pool *pool) > { > - struct page *page; > + struct netmem *nmem; > > /* Empty recycle ring */ > - while ((page = ptr_ring_consume_bh(&pool->ring))) { > + while ((nmem = ptr_ring_consume_bh(&pool->ring)) != NULL) { > /* Verify the refcnt invariant of cached pages */ > - if (!(page_ref_count(page) == 1)) > + if (netmem_ref_count(nmem) != 1) > pr_crit("%s() page_pool refcnt %d violation\n", > - __func__, page_ref_count(page)); > + __func__, netmem_ref_count(nmem)); > > - page_pool_return_page(pool, page); > + page_pool_return_netmem(pool, nmem); > } > } > > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Powered by blists - more mailing lists