lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <fcf4e29a-003c-6ba8-161f-b6a9e51bb449@engleder-embedded.com> Date: Tue, 10 Jan 2023 20:47:44 +0100 From: Gerhard Engleder <gerhard@...leder-embedded.com> To: Alexander H Duyck <alexander.duyck@...il.com>, netdev@...r.kernel.org Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com Subject: Re: [PATCH net-next v4 03/10] tsnep: Do not print DMA mapping error On 10.01.23 16:53, Alexander H Duyck wrote: > On Mon, 2023-01-09 at 20:15 +0100, Gerhard Engleder wrote: >> Printing in data path shall be avoided. DMA mapping error is already >> counted in stats so printing is not necessary. >> >> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com> >> --- >> drivers/net/ethernet/engleder/tsnep_main.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c >> index d148ba422b8c..8c6d6e210494 100644 >> --- a/drivers/net/ethernet/engleder/tsnep_main.c >> +++ b/drivers/net/ethernet/engleder/tsnep_main.c >> @@ -469,8 +469,6 @@ static netdev_tx_t tsnep_xmit_frame_ring(struct sk_buff *skb, >> >> spin_unlock_bh(&tx->lock); >> >> - netdev_err(tx->adapter->netdev, "TX DMA map failed\n"); >> - >> return NETDEV_TX_OK; >> } >> length = retval; > > It might be nice to add a stat to indicate that this is specifically a > mapping error rather than just incrementing dropped but that could also > be done in a future patch. I took a note for future work. Gerhard
Powered by blists - more mailing lists