lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <871qo2dq8z.fsf@cloudflare.com> Date: Tue, 10 Jan 2023 22:36:33 +0100 From: Jakub Sitnicki <jakub@...udflare.com> To: Eric Dumazet <edumazet@...gle.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, kernel-team@...udflare.com, Marek Majkowski <marek@...udflare.com> Subject: Re: [PATCH net-next v2 1/2] inet: Add IP_LOCAL_PORT_RANGE socket option On Tue, Jan 10, 2023 at 03:28 PM +01, Eric Dumazet wrote: > On Tue, Jan 10, 2023 at 2:37 PM Jakub Sitnicki <jakub@...udflare.com> wrote: >> >> Users who want to share a single public IP address for outgoing connections >> between several hosts traditionally reach for SNAT. However, SNAT requires >> state keeping on the node(s) performing the NAT. >> > >> v1 -> v2: >> * Fix the corner case when the per-socket range doesn't overlap with the >> per-netns range. Fallback correctly to the per-netns range. (Kuniyuki) >> >> Reviewed-by: Marek Majkowski <marek@...udflare.com> >> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com> >> --- >> include/net/inet_sock.h | 4 ++++ >> include/net/ip.h | 3 ++- >> include/uapi/linux/in.h | 1 + >> net/ipv4/inet_connection_sock.c | 25 +++++++++++++++++++++++-- >> net/ipv4/inet_hashtables.c | 2 +- >> net/ipv4/ip_sockglue.c | 18 ++++++++++++++++++ >> net/ipv4/udp.c | 2 +- >> 7 files changed, 50 insertions(+), 5 deletions(-) > > > Being an INET option, I think net/sctp/socket.c should also be changed. Will do. Should be a one-liner + test coverage. > Not clear if selinux_socket_bind() needs any change, I would CC > SELINUX maintainers for advice. I will start a thread. Thank you for taking a look.
Powered by blists - more mailing lists