lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230109165500.3bebda0a@kernel.org> Date: Mon, 9 Jan 2023 16:55:00 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Jiri Pirko <jiri@...nulli.us> Cc: netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, michael.chan@...adcom.com, yisen.zhuang@...wei.com, salil.mehta@...wei.com, jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, tariqt@...dia.com, saeedm@...dia.com, leon@...nel.org, idosch@...dia.com, petrm@...dia.com, mailhol.vincent@...adoo.fr, jacob.e.keller@...el.com, gal@...dia.com Subject: Re: [patch net-next v3 01/11] devlink: remove devlink features On Mon, 9 Jan 2023 19:31:10 +0100 Jiri Pirko wrote: > Note that mlx5 used this to enable devlink reload conditionally only > when device didn't act as multi port slave. Move the multi port check > into mlx5_devlink_reload_down() callback alongside with the other > checks preventing the device from reload in certain states. Right, but this is not 100% equivalent because we generate the notifications _before_ we try to reload_down: devlink_ns_change_notify(devlink, dest_net, curr_net, false); err = devlink->ops->reload_down(devlink, !!dest_net, action, limit, extack); if (err) return err; IDK why, I haven't investigated.
Powered by blists - more mailing lists