lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230109164500.7801c017@kernel.org> Date: Mon, 9 Jan 2023 16:45:00 -0800 From: Jakub Kicinski <kuba@...nel.org> To: David Arinzon <darinzon@...zon.com> Cc: David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>, "Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, Saeed Bshara <saeedb@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>, "Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, "Itzko, Shahar" <itzko@...zon.com>, "Abboud, Osama" <osamaabb@...zon.com> Subject: Re: [PATCH V1 net-next 0/5] Add devlink support to ena On Sun, 8 Jan 2023 10:35:28 +0000 David Arinzon wrote: > This patchset adds devlink support to the ena driver. Wrong place, please take a look at struct kernel_ethtool_ringparam::tx_push and ETHTOOL_A_RINGS_TX_PUSH. I think you just want to configure the max size of the TX push, right? The reload is also an overkill, reload should re-register all driver objects but the devlink instance, IIRC. You're not even unregistering the netdev. You should handle this change the same way you handle any ring size changes. For future reference - if you ever _actually_ need devlink please use the devl_* APIs and take the instance locks explicitly. There has not been a single devlink reload implementation which would get locking right using the devlink_* APIs 😔️
Powered by blists - more mailing lists