lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <be4814483f1b320eaaa49ba8d59d81b2a51f932b.camel@gmail.com> Date: Mon, 09 Jan 2023 16:50:55 -0800 From: Alexander H Duyck <alexander.duyck@...il.com> To: Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, lorenzo.bianconi@...hat.com, nbd@....name, john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com, sujuan.chen@...iatek.com, daniel@...rotopia.org Subject: Re: [PATCH net-next] net: ethernet: mtk_wed: get rid of queue lock for rx queue On Sat, 2023-01-07 at 15:41 +0100, Lorenzo Bianconi wrote: > mtk_wed_wo_queue_rx_clean and mtk_wed_wo_queue_refill routines can't run > concurrently so get rid of spinlock for rx queues. > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> My understanding is that mtk_wed_wo_queue_refill will only be called during init and by the tasklet. The mtk_wed_wo_queue_rx_clean function is only called during deinit and only after the tasklet has been disabled. That is the reason they cannot run at the same time correct? It would be nice if you explained why they couldn't run concurrently rather than just stating it is so in the patch description. It makes it easier to verify assumptions that way. Otherwise the patch itself looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@...com>
Powered by blists - more mailing lists