netdev - Re: [Intel-wired-lan] [PATCH net-queue] iavf: schedule watchdog immediately when changing primary MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADEbmW2LLTfZ6h=Cdkbc70Z61BuBKYMbaLYq-c=STP03VJ_O2g@mail.gmail.com>
Date:   Wed, 11 Jan 2023 10:42:32 +0100
From:   Michal Schmidt <mschmidt@...hat.com>
To:     Stefan Assmann <sassmann@...hat.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        patryk.piotrowski@...el.com, anthony.l.nguyen@...el.com,
        sassmann@...nic.de
Subject: Re: [Intel-wired-lan] [PATCH net-queue] iavf: schedule watchdog
 immediately when changing primary MAC

On Tue, Jan 10, 2023 at 9:01 AM Stefan Assmann <sassmann@...hat.com> wrote:
>
> From: Stefan Assmann <sassmann@...nic.de>
>
> iavf_replace_primary_mac() utilizes queue_work() to schedule the
> watchdog task but that only ensures that the watchdog task is queued
> to run. To make sure the watchdog is executed asap use
> mod_delayed_work().
>
> Without this patch it may take up to 2s until the watchdog task gets
> executed, which may cause long delays when setting the MAC address.
>
> Fixes: a3e839d539e0 ("iavf: Add usage of new virtchnl format to set default MAC")
> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> ---
> Depends on net-queue patch
> ca7facb6602f iavf: fix temporary deadlock and failure to set MAC address
>
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index fff06f876c2c..1d3aa740caea 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -1033,7 +1033,7 @@ int iavf_replace_primary_mac(struct iavf_adapter *adapter,
>
>         /* schedule the watchdog task to immediately process the request */
>         if (f) {
> -               queue_work(adapter->wq, &adapter->watchdog_task.work);
> +               mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
>                 return 0;
>         }
>         return -ENOMEM;
> --
> 2.38.1

Reviewed-by: Michal Schmidt <mschmidt@...hat.com>
Tested-by: Michal Schmidt <mschmidt@...hat.com>

Beautiful! On my test machine, this takes the time needed to bring up
64 VFs from 92 s down to 7 s.
Michal