netdev - RE: [Intel-wired-lan] [PATCH net-queue] iavf: schedule watchdog immediately when changing primary MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL0PR11MB3521C08FE39C9C9CFAE98F268FC49@BL0PR11MB3521.namprd11.prod.outlook.com>
Date:   Thu, 19 Jan 2023 12:21:57 +0000
From:   "Romanowski, Rafal" <rafal.romanowski@...el.com>
To:     mschmidt <mschmidt@...hat.com>,
        Stefan Assmann <sassmann@...hat.com>
CC:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Piotrowski, Patryk" <patryk.piotrowski@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "sassmann@...nic.de" <sassmann@...nic.de>
Subject: RE: [Intel-wired-lan] [PATCH net-queue] iavf: schedule watchdog
 immediately when changing primary MAC

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Michal Schmidt
> Sent: środa, 11 stycznia 2023 10:43
> To: Stefan Assmann <sassmann@...hat.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> netdev@...r.kernel.org; Piotrowski, Patryk <patryk.piotrowski@...el.com>;
> intel-wired-lan@...ts.osuosl.org; sassmann@...nic.de
> Subject: Re: [Intel-wired-lan] [PATCH net-queue] iavf: schedule watchdog
> immediately when changing primary MAC
> 
> On Tue, Jan 10, 2023 at 9:01 AM Stefan Assmann <sassmann@...hat.com>
> wrote:
> >
> > From: Stefan Assmann <sassmann@...nic.de>
> >
> > iavf_replace_primary_mac() utilizes queue_work() to schedule the
> > watchdog task but that only ensures that the watchdog task is queued
> > to run. To make sure the watchdog is executed asap use
> > mod_delayed_work().
> >
> > Without this patch it may take up to 2s until the watchdog task gets
> > executed, which may cause long delays when setting the MAC address.
> >
> > Fixes: a3e839d539e0 ("iavf: Add usage of new virtchnl format to set
> > default MAC")
> > Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> > ---
> > Depends on net-queue patch
> > ca7facb6602f iavf: fix temporary deadlock and failure to set MAC
> > address
> >
> >  drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > index fff06f876c2c..1d3aa740caea 100644
> > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>