netdev - Re: [PATCH iproute2 v3 1/1] macsec: Fix Macsec replay protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y76aOvxVcW/upwjl@hog>
Date:   Wed, 11 Jan 2023 12:15:06 +0100
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     ehakim@...dia.com
Cc:     dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v3 1/1] macsec: Fix Macsec replay protection

2023-01-11, 09:32:59 +0200, ehakim@...dia.com wrote:
> From: Emeel Hakim <ehakim@...dia.com>
> 
> Currently when configuring macsec with replay protection,
> replay protection and window gets a default value of -1,
> the above is leading to passing replay protection and
> replay window attributes to the kernel while replay is
> explicitly set to off, leading for an invalid argument
> error when configured with extended packet number (XPN).
> since the default window value which is 0xFFFFFFFF is
> passed to the kernel and while XPN is configured the above
> value is an invalid window value.
> 
> Example:
> ip link add link eth2 macsec0 type macsec sci 1 cipher
> gcm-aes-xpn-128 replay off
> 
> RTNETLINK answers: Invalid argument
> 
> Fix by passing the window attribute to the kernel only if replay is on
> 
> Fixes: b26fc590ce62 ("ip: add MACsec support")
> Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks Emeel.

-- 
Sabrina