netdev - Re: [PATCH net] net: ethernet: renesas: rswitch: Fix ethernet-ports handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230111201857.6610f412@kernel.org>
Date:   Wed, 11 Jan 2023 20:18:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: renesas: rswitch: Fix ethernet-ports
 handling

On Tue, 10 Jan 2023 18:55:59 +0900 Yoshihiro Shimoda wrote:
> +#define rswitch_for_each_enabled_port_reverse(priv, i)	\
> +	for (i--; i >= 0; i--)				\

nit: the typical name suffix for this sort of macro in Linux would 
be _continue_reverse - because it doesn't initialize the iterator.
It's specifically targeting error paths.

That's what list.h uses, on a quick grep I can see the same convention
is used for netdevice.h and dsa.h. Do you have counter examples?
I reckon we should throw "_continue" into the name.