netdev - RE: [PATCH net] net: ethernet: renesas: rswitch: Fix ethernet-ports handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYBPR01MB534114015F5BF595A533A031D8FD9@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date:   Thu, 12 Jan 2023 07:35:41 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net] net: ethernet: renesas: rswitch: Fix ethernet-ports
 handling

Hi Jakub,

> From: Jakub Kicinski, Sent: Thursday, January 12, 2023 1:19 PM
> 
> On Tue, 10 Jan 2023 18:55:59 +0900 Yoshihiro Shimoda wrote:
> > +#define rswitch_for_each_enabled_port_reverse(priv, i)	\
> > +	for (i--; i >= 0; i--)				\
> 
> nit: the typical name suffix for this sort of macro in Linux would
> be _continue_reverse - because it doesn't initialize the iterator.
> It's specifically targeting error paths.
> 
> That's what list.h uses, on a quick grep I can see the same convention
> is used for netdevice.h and dsa.h. Do you have counter examples?
> I reckon we should throw "_continue" into the name.

Thank you for your comments! I didn't know suffix "__continue_" on macros.
So, I will rename this macro name with rswitch_for_each_enabled_port_continue_reverse().

Best regards,
Yoshihiro Shimoda