netdev - Re: [PATCH v3 08/26] page_pool: Convert pp_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8LtYEfdrN+cWiVm@casper.infradead.org>
Date:   Sat, 14 Jan 2023 17:58:56 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Shay Agroskin <shayagr@...zon.com>
Cc:     Jesper Dangaard Brouer <hawk@...nel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        netdev@...r.kernel.org, linux-mm@...ck.org,
        Shakeel Butt <shakeelb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH v3 08/26] page_pool: Convert pp_alloc_cache to contain
 netmem

On Sat, Jan 14, 2023 at 02:28:50PM +0200, Shay Agroskin wrote:
> >  	memset(&pool->alloc.cache, 0, sizeof(void *) * bulk);
> >    	nr_pages = alloc_pages_bulk_array_node(gfp, pool->p.nid,  bulk,
> > -					       pool->alloc.cache);
> > +					(struct page **)pool->alloc.cache);
> 
> Can you fix the alignment here (so that the '(struct page **)' would align
> the the 'gfp' argument one line above) ?

No, that makes the line too long.