netdev - Re: [PATCH v3 08/26] page_pool: Convert pp_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pj41zlo7r011u8.fsf@u570694869fb251.ant.amazon.com>
Date:   Sun, 15 Jan 2023 13:03:41 +0200
From:   Shay Agroskin <shayagr@...zon.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     Jesper Dangaard Brouer <hawk@...nel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        <netdev@...r.kernel.org>, <linux-mm@...ck.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        "Jesper Dangaard Brouer" <brouer@...hat.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH v3 08/26] page_pool: Convert pp_alloc_cache to contain netmem


Matthew Wilcox <willy@...radead.org> writes:

> CAUTION: This email originated from outside of the 
> organization. Do not click links or open attachments unless you 
> can confirm the sender and know the content is safe.
>
>
>
> On Sat, Jan 14, 2023 at 02:28:50PM +0200, Shay Agroskin wrote:
>> >     memset(&pool->alloc.cache, 0, sizeof(void *) * bulk);
>> >     nr_pages = alloc_pages_bulk_array_node(gfp, pool->p.nid, 
>> >     bulk,
>> > - 
>> > pool->alloc.cache);
>> > +                                   (struct page 
>> > **)pool->alloc.cache);
>>
>> Can you fix the alignment here (so that the '(struct page **)' 
>> would align
>> the the 'gfp' argument one line above) ?
>
> No, that makes the line too long.

Couldn't find any word about inlining in the coding style. AFAIK 
82 characters line is considered ok (and the file you're editing 
has even longer lines than that). To me it'd look better aligned, 
but suit yourself