netdev - Re: [net-next 02/15] net/mlx5: Suppress error logging on UCTX creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89b5a36a-96f4-5bc3-1b02-c88925fe49ee@intel.com>
Date:   Wed, 18 Jan 2023 13:32:17 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
CC:     Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Maor Gottlieb <maorg@...dia.com>
Subject: Re: [net-next 02/15] net/mlx5: Suppress error logging on UCTX
 creation



On 1/18/2023 10:35 AM, Saeed Mahameed wrote:
> From: Yishai Hadas <yishaih@...dia.com>
> 
> Suppress error logging that can be triggered by userspace upon DEVX UCTX
> creation.
> 
> The reason that it's not suppressed today with the uid check to suppress
> DEVX is that MLX5_CMD_OP_CREATE_UCTX command still doesn't have a uid as
> it comes to create it..
> 

uid isn't added until later in the create flow. ok.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Signed-off-by: Yishai Hadas <yishaih@...dia.com>
> Reviewed-by: Maor Gottlieb <maorg@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> index c3c8a7148723..382d02f6619c 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -813,7 +813,8 @@ static void cmd_status_print(struct mlx5_core_dev *dev, void *in, void *out)
>  	op_mod = MLX5_GET(mbox_in, in, op_mod);
>  	uid    = MLX5_GET(mbox_in, in, uid);
>  
> -	if (!uid && opcode != MLX5_CMD_OP_DESTROY_MKEY)
> +	if (!uid && opcode != MLX5_CMD_OP_DESTROY_MKEY &&
> +	    opcode != MLX5_CMD_OP_CREATE_UCTX)
>  		mlx5_cmd_out_err(dev, opcode, op_mod, out);
>  }
>