netdev - Re: [net-next 05/15] net/mlx5: E-switch, Remove redundant comment about meta rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a502e055-2210-0831-531b-3fdc9ff545e0@intel.com>
Date:   Wed, 18 Jan 2023 13:40:13 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
CC:     Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>, Roi Dayan <roid@...dia.com>,
        Maor Dickman <maord@...dia.com>
Subject: Re: [net-next 05/15] net/mlx5: E-switch, Remove redundant comment
 about meta rules



On 1/18/2023 10:35 AM, Saeed Mahameed wrote:
> From: Roi Dayan <roid@...dia.com>
> 
> Meta rules are created/destroyed per vport and not in eswitch
> init/destroy.
> 
> Signed-off-by: Roi Dayan <roid@...dia.com>
> Reviewed-by: Maor Dickman <maord@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> index bbb6dab3b21f..05a352d8d13f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> @@ -1406,9 +1406,7 @@ void mlx5_eswitch_disable_sriov(struct mlx5_eswitch *esw, bool clear_vf)
>  	mlx5_eswitch_unload_vf_vports(esw, esw->esw_funcs.num_vfs);
>  	if (clear_vf)
>  		mlx5_eswitch_clear_vf_vports_info(esw);
> -	/* If disabling sriov in switchdev mode, free meta rules here
> -	 * because it depends on num_vfs.
> -	 */
> +

The comment was added in f019679ea5f2 ("net/mlx5: E-switch, Remove
dependency between sriov and eswitch mode") which included the line
esw_offloads_del_send_to_vport_meta_rules(esw);

That was removed in 430e2d5e2a98 ("net/mlx5: E-Switch, Move send to
vport meta rule creation")

This could be viewed as:

Fixes: 430e2d5e2a98 ("net/mlx5: E-Switch, Move send to vport meta rule
creation")

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  	if (esw->mode == MLX5_ESWITCH_OFFzLOADS) {
>  		struct devlink *devlink = priv_to_devlink(esw->dev);
>