netdev - Re: [net-next 06/15] net/mlx5e: Fail with messages when params are not valid for XSK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2023 13:41:40 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
CC:     Saeed Mahameed <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Adham Faris <afaris@...dia.com>
Subject: Re: [net-next 06/15] net/mlx5e: Fail with messages when params are
 not valid for XSK



On 1/18/2023 10:35 AM, Saeed Mahameed wrote:
> From: Adham Faris <afaris@...dia.com>
> 
> Current XSK prerequisites validation implementation
> (setup.c/mlx5e_validate_xsk_param()) fails silently when xsk
> prerequisites are not fulfilled.
> Add error messages to the kernel log to help the user understand what
> went wrong when params are not valid for XSK.
> 
> Signed-off-by: Adham Faris <afaris@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

Makes sense. I'm not familiar with the XSK configuration but I assume we
don't have netlink_ext_ack or similar for error message reporting here.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>