netdev - Re: [PATCH net-next v2 4/4] net: dsa: microchip: enable EEE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jan 2023 14:25:12 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <olteanv@...il.com>, <UNGLinuxDriver@...rochip.com>,
        <vivien.didelot@...il.com>, <andrew@...n.ch>,
        <f.fainelli@...il.com>, <kuba@...nel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <o.rempel@...gutronix.de>,
        <Woojung.Huh@...rochip.com>, <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <kernel@...gutronix.de>
Subject: Re: [PATCH net-next v2 4/4] net: dsa: microchip: enable EEE support

Hi Oleksij,

On Fri, 2023-01-20 at 10:20 +0100, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Some of KSZ9477 family switches provides EEE support. To enable it,
> we
> just need to register set_mac_eee/set_mac_eee handlers and validate
> supported chip version and port.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  drivers/net/dsa/microchip/ksz_common.c | 35
> ++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/ksz_common.c
> b/drivers/net/dsa/microchip/ksz_common.c
> index 5e1e5bd555d2..2f1f71b3be86 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -2645,6 +2645,39 @@ static int ksz_max_mtu(struct dsa_switch *ds,
> int port)
>         return -EOPNOTSUPP;
>  }
> 
> +static int ksz_validate_eee(struct dsa_switch *ds, int port)
> +{
> +       struct ksz_device *dev = ds->priv;
> +
> +       if (!dev->info->internal_phy[port])
> +               return -EOPNOTSUPP;
> +
> +       switch (dev->chip_id) {
> +       case KSZ8563_CHIP_ID:
> +       case KSZ9477_CHIP_ID:
> +       case KSZ9563_CHIP_ID:
> +       case KSZ9567_CHIP_ID:
> +       case KSZ9893_CHIP_ID:
> +       case KSZ9896_CHIP_ID:
> +       case KSZ9897_CHIP_ID:
> +               return 0;
> +       }
> +
> +       return -EOPNOTSUPP;
> +}
> +
> +static int ksz_get_mac_eee(struct dsa_switch *ds, int port,
> +                          struct ethtool_eee *e)
> +{
> +       return ksz_validate_eee(ds, port);
> +}
> +
> +static int ksz_set_mac_eee(struct dsa_switch *ds, int port,
> +                          struct ethtool_eee *e)
> +{
> +       return ksz_validate_eee(ds, port);
> +}
> +

nit: As both set and get function perform the same operation, we can
assign .get_mac_eee and .set_mac_eee to ksz_validate_eee function by
changing its prototype. In future, if any things to be added specific
to get or set, we can separate it to two function.

>  static void ksz_set_xmii(struct ksz_device *dev, int port,
>                          phy_interface_t interface)
>  {
> @@ -3006,6 +3039,8 @@ static const struct dsa_switch_ops
> ksz_switch_ops = {
>         .port_hwtstamp_set      = ksz_hwtstamp_set,
>         .port_txtstamp          = ksz_port_txtstamp,
>         .port_rxtstamp          = ksz_port_rxtstamp,
> +       .get_mac_eee            = ksz_get_mac_eee,
> +       .set_mac_eee            = ksz_set_mac_eee,
>  };
> 
>  struct ksz_device *ksz_switch_alloc(struct device *base, void *priv)
> --
> 2.30.2
>