netdev - Re: [PATCH net-next] net: microchip: sparx5: Fix uninitialized variable in vcap_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jan 2023 15:25:36 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Dan Carpenter <error27@...il.com>
CC:     Daniel Machon <daniel.machon@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        Lars Povlsen <lars.povlsen@...rochip.com>
Subject: Re: [PATCH net-next] net: microchip: sparx5: Fix uninitialized
 variable in vcap_path_exist()

Hi Dan,

Thanks for the fix.

I have not seen any CONFIG_INIT_STACK_ALL=y in any of my .configs, though, so I
will be updating my test suite to catch this.

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

On Fri, 2023-01-20 at 16:47 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> The "eport" variable needs to be initialized to NULL for this code to
> work.
> 
> Fixes: 814e7693207f ("net: microchip: vcap api: Add a storage state to a VCAP
> rule")
> Signed-off-by: Dan Carpenter <error27@...il.com>
> ---
> Probably you had CONFIG_INIT_STACK_ALL=y in your .config for this to
> pass testing.
> 
>  drivers/net/ethernet/microchip/vcap/vcap_api.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> index 71f787a78295..69c026778b42 100644
> --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> @@ -2012,7 +2012,8 @@ static int vcap_get_next_chain(struct vcap_control
> *vctrl,
>  static bool vcap_path_exist(struct vcap_control *vctrl, struct net_device
> *ndev,
>                             int dst_cid)
>  {
> -       struct vcap_enabled_port *eport, *elem;
> +       struct vcap_enabled_port *eport = NULL;
> +       struct vcap_enabled_port *elem;
>         struct vcap_admin *admin;
>         int tmp;
> 
> --
> 2.35.1
> 

BR
Steen