netdev - Re: [PATCH net-next] net: microchip: sparx5: Fix uninitialized variable in vcap_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8qu6s4nmOQB8ZEq@kadam>
Date:   Fri, 20 Jan 2023 18:10:34 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     Daniel Machon <daniel.machon@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Lars Povlsen <lars.povlsen@...rochip.com>
Subject: Re: [PATCH net-next] net: microchip: sparx5: Fix uninitialized
 variable in vcap_path_exist()

On Fri, Jan 20, 2023 at 03:25:36PM +0100, Steen Hegelund wrote:
> Hi Dan,
> 
> Thanks for the fix.
> 
> I have not seen any CONFIG_INIT_STACK_ALL=y in any of my .configs, though, so I
> will be updating my test suite to catch this.

No, what I'm saying is that for a lot of people all stack variables are
initialized to zero by default so sometimes people are like, "I've
tested this a thousand times.  How has it even been working?"

In your case I guess it was working because the eport was never not
found.

regards,
dan carpenter