netdev - Re: [PATCH net-next] tsnep: Fix TX queue stop/wake for multiple queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b7dbb0a7e228faea3ffe5737969eb3fd3492a27.camel@redhat.com>
Date:   Tue, 24 Jan 2023 13:07:15 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] tsnep: Fix TX queue stop/wake for multiple
 queues

Hello,

On Sun, 2023-01-22 at 20:04 +0100, Gerhard Engleder wrote:
> netif_stop_queue() and netif_wake_queue() act on TX queue 0. This is ok
> as long as only a single TX queue is supported. But support for multiple
> TX queues was introduced with 762031375d5c and I missed to adapt stop
> and wake of TX queues.
> 
> Use netif_stop_subqueue() and netif_tx_wake_queue() to act on specific
> TX queue.
> 
> Fixes: 762031375d5c ("tsnep: Support multiple TX/RX queue pairs")
> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>

Any special reason to have this on net-next instead of on the net tree?
The fix is reasonably small and safe and the culprit commit is on net
already.

Thanks,

Paolo