netdev - Re: [PATCH net-next] tsnep: Fix TX queue stop/wake for multiple queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b90b632-b442-be66-5036-a818c683ccdc@engleder-embedded.com>
Date:   Tue, 24 Jan 2023 19:59:59 +0100
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] tsnep: Fix TX queue stop/wake for multiple
 queues

On 24.01.23 13:07, Paolo Abeni wrote:
> Hello,
> 
> On Sun, 2023-01-22 at 20:04 +0100, Gerhard Engleder wrote:
>> netif_stop_queue() and netif_wake_queue() act on TX queue 0. This is ok
>> as long as only a single TX queue is supported. But support for multiple
>> TX queues was introduced with 762031375d5c and I missed to adapt stop
>> and wake of TX queues.
>>
>> Use netif_stop_subqueue() and netif_tx_wake_queue() to act on specific
>> TX queue.
>>
>> Fixes: 762031375d5c ("tsnep: Support multiple TX/RX queue pairs")
>> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
> 
> Any special reason to have this on net-next instead of on the net tree?
> The fix is reasonably small and safe and the culprit commit is on net
> already.

Not really. May I'm too shy to send to net. I will repost to net. Commit
will grow a little, but those additional lines should make a future
merge more straightforward.

Gerhard