netdev - Re: [PATCH v3 net 1/3] net: mediatek: sgmii: ensure the SGMII PHY is powered down on configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lelsp12b.fsf@miraculix.mork.no>
Date:   Tue, 24 Jan 2023 13:30:20 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Felix Fietkau <nbd@....name>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Daniel Golle <daniel@...rotopia.org>,
        Alexander Couzens <lynxis@...0.eu>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH v3 net 1/3] net: mediatek: sgmii: ensure the SGMII PHY
 is powered down on configuration

Paolo Abeni <pabeni@...hat.com> writes:
> On Sun, 2023-01-22 at 22:21 +0100, Bjørn Mork wrote:
>> From: Alexander Couzens <lynxis@...0.eu>
>> 
>> The code expect the PHY to be in power down which is only true after reset.
>> Allow changes of the SGMII parameters more than once.
>> 
>> Only power down when reconfiguring to avoid bouncing the link when there's
>> no reason to - based on code from Russell King.
>> 
>> There are cases when the SGMII_PHYA_PWD register contains 0x9 which
>> prevents SGMII from working. The SGMII still shows link but no traffic
>> can flow. Writing 0x0 to the PHYA_PWD register fix the issue. 0x0 was
>> taken from a good working state of the SGMII interface.
>
> This looks like a legitimate fix for -net, but we need a suitable Fixes
> tag pointing to the culprit commit.
>
> Please repost including such tag. While at that you could also consider
> including Simon's suggestion.

Thanks.  Will do.  Taking advantage of the hole is a good idea.

> The following 2 patches looks like new features/refactor that would be
> more suitable for net-next, and included here due to the code
> dependency.
>
> If so, please repost the later 2 separately for net-next after the fix
> will land there.

I believe all these 3 patches are fixes and therefore appropriate for
net.  I will verify and add Fixes tags for all of them.


Bjørn