netdev - [PATCH] arm64: ls1046ardb: Use in-band-status for SFP module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230124174757.2956299-1-sean.anderson@seco.com>
Date:   Tue, 24 Jan 2023 12:47:57 -0500
From:   Sean Anderson <sean.anderson@...o.com>
To:     Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     netdev@...r.kernel.org, Madalin Bucur <madalin.bucur@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-kernel@...r.kernel.org,
        Sean Anderson <sean.anderson@...o.com>
Subject: [PATCH] arm64: ls1046ardb: Use in-band-status for SFP module

net10 is connected to an SFP module. Unfortunately, the I2C lines are
not connected due to an address conflict. Now that DPAA uses phylink, we
can use in-band-status. This lets us determine whether the link is up or
down instead of assuming it is up all the time. Also fix the phy mode
while we're here.

Signed-off-by: Sean Anderson <sean.anderson@...o.com>
---
This should likely go through Shawn Guo's tree, although it could also
go through net-next. It will conflict with [1] which modifies the
adjoining lines and is likely to go through the phy tree.

[1] https://lore.kernel.org/linux-phy/Y8pLjLWjv0nJa+ww@matsya/T/#m54a5ed1450322df1499836edbb561bc4d6daf4d8

 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 7025aad8ae89..07f6cc6e354a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -153,8 +153,8 @@ ethernet@...00 { /* 10GEC1 */
 	};
 
 	ethernet@...00 { /* 10GEC2 */
-		fixed-link = <0 1 1000 0 0>;
-		phy-connection-type = "xgmii";
+		phy-connection-type = "10gbase-r";
+		managed = "in-band-status";
 	};
 
 	mdio@...00 {
-- 
2.35.1.1320.gc452695387.dirty