netdev - Re: [PATCH net-next v4 5/8] net: fou: regenerate the uAPI from the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a16382e3-b66f-0a57-2482-72afd00cdabe@intel.com>
Date:   Tue, 24 Jan 2023 18:49:48 +0100
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <edumazet@...gle.com>, <pabeni@...hat.com>, <robh@...nel.org>,
        <johannes@...solutions.net>, <stephen@...workplumber.org>,
        <ecree.xilinx@...il.com>, <sdf@...gle.com>, <f.fainelli@...il.com>,
        <fw@...len.de>, <linux-doc@...r.kernel.org>, <razor@...ckwall.org>,
        <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH net-next v4 5/8] net: fou: regenerate the uAPI from the
 spec

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 20 Jan 2023 09:50:38 -0800

> Regenerate the FOU uAPI header from the YAML spec.
> 
> The flags now come before attributes which use them,
> and the comments for type disappear (coders should look
> at the spec instead).

Sorry I missed the whole history of this topic. Wanted to ask: if we can
generate these headers and even C files, why ship the generated with the
source code and not generate them during building? Or it's slow and/or
requires some software etc.?

> 
> Acked-by: Stanislav Fomichev <sdf@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  include/uapi/linux/fou.h | 54 +++++++++++++++++++---------------------
>  1 file changed, 26 insertions(+), 28 deletions(-)

[...]

> -#define FOU_CMD_MAX	(__FOU_CMD_MAX - 1)
> +#define FOU_CMD_MAX (__FOU_CMD_MAX - 1)
>  
>  #endif /* _UAPI_LINUX_FOU_H */

Thanks,
Olek