netdev - Re: [PATCH] ca8210: move to gpio descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <57e74219-d439-4d10-9bb5-53fe7b30b46f@app.fastmail.com>
Date:   Thu, 26 Jan 2023 17:25:29 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Arnd Bergmann" <arnd@...nel.org>,
        "Alexander Aring" <alex.aring@...il.com>,
        "Stefan Schmidt" <stefan@...enfreihafen.org>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Hauke Mehrtens" <hauke@...ke-m.de>, linux-wpan@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ca8210: move to gpio descriptors

On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote:

>  	if (ret) {
> -		dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
> -		gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
> -		gpio_free(pdata->gpio_irq);
> +		dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id);
> +		gpiod_put(priv->gpio_irq);
>  	}

I just realized that this bit depends on the "gpiolib: remove
legacy gpio_export" patch I sent to the gpio mailing list earlier.

We can probably just defer this change until that is merged,
or alternatively I can rebase this patch to avoid the
dependency.

   Arnd