[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a09a41b-1eb9-edc9-28ad-acb920e04ae4@datenfreihafen.org>
Date: Sat, 28 Jan 2023 14:30:17 +0100
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Arnd Bergmann <arnd@...db.de>, Arnd Bergmann <arnd@...nel.org>,
Alexander Aring <alex.aring@...il.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Hauke Mehrtens <hauke@...ke-m.de>, linux-wpan@...r.kernel.org,
Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ca8210: move to gpio descriptors
Hello Arnd.
On 26.01.23 17:25, Arnd Bergmann wrote:
> On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote:
>
>> if (ret) {
>> - dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
>> - gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
>> - gpio_free(pdata->gpio_irq);
>> + dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id);
>> + gpiod_put(priv->gpio_irq);
>> }
>
> I just realized that this bit depends on the "gpiolib: remove
> legacy gpio_export" patch I sent to the gpio mailing list earlier.
>
> We can probably just defer this change until that is merged,
> or alternatively I can rebase this patch to avoid the
> dependency.
Deferring the change until i picked it up from Linus or net-next in my
tree is fine. This driver is not heavily worked on (its actually marked
as orphaned) so the patch should still apply in a few days.
I will keep it in my patchwork queue of patches to be applied. No extra
work needed from your side.
regards
Stefan Schmidt
Powered by blists - more mailing lists