[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9LDIvWiG9gSl9f2@unreal>
Date: Thu, 26 Jan 2023 20:14:58 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-gpio@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wiznet: convert to GPIO descriptors
On Thu, Jan 26, 2023 at 02:54:12PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The w5100/w5300 drivers only support probing with old platform data in
> MMIO mode, or probing with DT in SPI mode. There are no users of this
> platform data in tree, and from the git history it appears that the only
> users of MMIO mode were on the (since removed) blackfin architecture.
>
> Remove the platform data option, as it's unlikely to still be needed, and
> change the internal operation to GPIO descriptors, making the behavior
> the same for SPI and MMIO mode. The other data in the platform_data
> structure is the MAC address, so make that also handled the same for both.
>
> It would probably be possible to just remove the MMIO mode driver
> completely, but it seems fine otherwise, and fixing it to use the modern
> interface seems easy enough.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> .../devicetree/bindings/net/wiznet,w5x00.txt | 4 +-
> drivers/net/ethernet/wiznet/w5100-spi.c | 21 ++-----
> drivers/net/ethernet/wiznet/w5100.c | 57 ++++++++++---------
> drivers/net/ethernet/wiznet/w5100.h | 3 +-
> drivers/net/ethernet/wiznet/w5300.c | 52 ++++++++++-------
> include/linux/platform_data/wiznet.h | 23 --------
> 6 files changed, 70 insertions(+), 90 deletions(-)
> delete mode 100644 include/linux/platform_data/wiznet.h
<...>
> #include "w5100.h"
>
> @@ -139,6 +139,12 @@ MODULE_LICENSE("GPL");
> #define W5500_RX_MEM_START 0x30000
> #define W5500_RX_MEM_SIZE 0x04000
>
> +#ifndef CONFIG_WIZNET_BUS_SHIFT
> +#define CONFIG_WIZNET_BUS_SHIFT 0
> +#endif
I don't see any define of CONFIG_WIZNET_BUS_SHIFT in the code, so it looks
like it always zero and can be removed.
Thanks
Powered by blists - more mailing lists