netdev - Re: [PATCH] wiznet: convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5313ee39-7313-493b-9b66-a9c697962831@app.fastmail.com>
Date:   Thu, 26 Jan 2023 19:41:19 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Leon Romanovsky" <leon@...nel.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Netdev <netdev@...r.kernel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wiznet: convert to GPIO descriptors

On Thu, Jan 26, 2023, at 19:14, Leon Romanovsky wrote:
> On Thu, Jan 26, 2023 at 02:54:12PM +0100, Arnd Bergmann wrote:
>>  
>> @@ -139,6 +139,12 @@ MODULE_LICENSE("GPL");
>>  #define W5500_RX_MEM_START	0x30000
>>  #define W5500_RX_MEM_SIZE	0x04000
>>  
>> +#ifndef CONFIG_WIZNET_BUS_SHIFT
>> +#define CONFIG_WIZNET_BUS_SHIFT 0
>> +#endif
>
> I don't see any define of CONFIG_WIZNET_BUS_SHIFT in the code, so it looks
> like it always zero and can be removed.

Good catch! Evidently the original idea was that this would
be set to a machine specific value through Kconfig. I've renamed
the constant, removed the #ifdef and explained it in the changelog
text now.

     Arnd