netdev - Re: [RFC PATCH net-next 14/15] net/sched: taprio: split segmentation logic from qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tu0auakx.fsf@kurt>
Date:   Sat, 28 Jan 2023 13:07:10 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [RFC PATCH net-next 14/15] net/sched: taprio: split
 segmentation logic from qdisc_enqueue()

On Sat Jan 28 2023, Vladimir Oltean wrote:
> The majority of the taprio_enqueue()'s function is spent doing TCP
> segmentation, which doesn't look right to me. Compilers shouldn't have a
> problem in inlining code no matter how we write it, so move the
> segmentation logic to a separate function.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)