netdev - Re: [RFC PATCH net-next 15/15] net/sched: taprio: don't segment unnecessarily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0veuakl.fsf@kurt>
Date:   Sat, 28 Jan 2023 13:07:22 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [RFC PATCH net-next 15/15] net/sched: taprio: don't segment
 unnecessarily

On Sat Jan 28 2023, Vladimir Oltean wrote:
> Improve commit 497cc00224cf ("taprio: Handle short intervals and large
> packets") to only perform segmentation when skb->len exceeds what
> taprio_dequeue() expects.
>
> In practice, this will make the biggest difference when a traffic class
> gate is always open in the schedule. This is because the max_frm_len
> will be U32_MAX, and such large skb->len values as Kurt reported will be
> sent just fine unsegmented.
>
> What I don't seem to know how to handle is how to make sure that the
> segmented skbs themselves are smaller than the maximum frame size given
> by the current queueMaxSDU[tc]. Nonetheless, we still need to drop
> those, otherwise the Qdisc will hang.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)