netdev - Re: [RFC PATCH net-next 01/15] net/sched: taprio: delete peek() implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v8kqvpih.fsf@kurt>
Date:   Sat, 28 Jan 2023 12:59:18 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [RFC PATCH net-next 01/15] net/sched: taprio: delete peek()
 implementation

On Sat Jan 28 2023, Vladimir Oltean wrote:
> There isn't any code in the network stack which calls taprio_peek().
> We only see qdisc->ops->peek() being called on child qdiscs of other
> classful qdiscs, never from the generic qdisc code. Whereas taprio is
> never a child qdisc, it is always root.
>
> This snippet of a comment from qdisc_peek_dequeued() seems to confirm:
>
> 	/* we can reuse ->gso_skb because peek isn't called for root qdiscs */
>
> Since I've been known to be wrong many times though, I'm not completely
> removing it, but leaving a stub function in place which emits a warning.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)