netdev - Re: [RFC PATCH net-next 02/15] net/sched: taprio: continue with other TXQs if one dequeue() failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Jan 2023 12:59:36 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [RFC PATCH net-next 02/15] net/sched: taprio: continue with
 other TXQs if one dequeue() failed

On Sat Jan 28 2023, Vladimir Oltean wrote:
> This changes the handling of an unlikely condition to not stop dequeuing
> if taprio failed to dequeue the peeked skb in taprio_dequeue().
>
> I've no idea when this can happen, but the only side effect seems to be
> that the atomic_sub_return() call right above will have consumed some
> budget. This isn't a big deal, since either that made us remain without
> any budget (and therefore, we'd exit on the next peeked skb anyway), or
> we could send some packets from other TXQs.
>
> I'm making this change because in a future patch I'll be refactoring the
> dequeue procedure to simplify it, and this corner case will have to go
> away.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)