netdev - Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4f4392f-cc15-86e0-9b63-12678b65d58f@kernel.org>
Date:   Sun, 29 Jan 2023 11:14:34 -0700
From:   David Ahern <dsahern@...nel.org>
To:     Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>,
        davem@...emloft.net, yoshfuji@...ux-ipv6.org, pabeni@...hat.com,
        edumazet@...gle.com, kuba@...nel.org, a@...table.cc,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not
 generating IPv6 link local address

A couple of nits.

On 1/26/23 7:59 PM, Thomas Winter wrote:
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index f7a84a4acffc..0065b38fc85b 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3355,7 +3355,7 @@ static void addrconf_addr_gen(struct inet6_dev *idev, bool prefix_route)
>  	}
>  }
>  
> -static void addrconf_dev_config(struct net_device *dev)
> +static void addrconf_eth_config(struct net_device *dev)

why the rename of this function? It does more than ethernet config.


>  {
>  	struct inet6_dev *idev;
>  
> @@ -3447,6 +3447,30 @@ static void addrconf_gre_config(struct net_device *dev)
>  }
>  #endif
>  
> +static void addrconfig_init_auto_addrs(struct net_device *dev)

this one should be 'addrconf_' to be consistent with related function names.