netdev - Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 03:32:55 +0000
From:   Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "a@...table.cc" <a@...table.cc>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not
 generating IPv6 link local address

On Sun, 2023-01-29 at 11:14 -0700, David Ahern wrote:
> A couple of nits.
> 
> On 1/26/23 7:59 PM, Thomas Winter wrote:
> > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> > index f7a84a4acffc..0065b38fc85b 100644
> > --- a/net/ipv6/addrconf.c
> > +++ b/net/ipv6/addrconf.c
> > @@ -3355,7 +3355,7 @@ static void addrconf_addr_gen(struct
> > inet6_dev *idev, bool prefix_route)
> >  	}
> >  }
> >  
> > -static void addrconf_dev_config(struct net_device *dev)
> > +static void addrconf_eth_config(struct net_device *dev)
> 
> why the rename of this function? It does more than ethernet config.

A remnant of a previous version where I named the new function
addrconf_dev_config which then calls addrconf_eth_config,
addrconf_gre_config, etc.

There is also the following comment in the function "Alas, we support
only Ethernet autoconfiguration.".

I could rename it back in the next patchset version.

> 
> 
> >  {
> >  	struct inet6_dev *idev;
> >  
> > @@ -3447,6 +3447,30 @@ static void addrconf_gre_config(struct
> > net_device *dev)
> >  }
> >  #endif
> >  
> > +static void addrconfig_init_auto_addrs(struct net_device *dev)
> 
> this one should be 'addrconf_' to be consistent with related function
> names.
> 
> 

Will update in new patch set.