netdev - Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230130184452.396762f8@wim.fritz.box>
Date:   Mon, 30 Jan 2023 18:44:52 +0100
From:   Jeroen Roovers <jer@...all.nl>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     netdev@...r.kernel.org, Simon Horman <simon.horman@...igine.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")

On Sun, 29 Jan 2023 20:53:08 +0100
Jonathan Neuschäfer <j.neuschaefer@....net> wrote:

> Spell them as "default" and "heartbeat".
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
> 
> v2:
> - also fix "hearbeat", as suggested by Simon Horman
> ---
>  drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h
> b/drivers/net/ethernet/dec/tulip/tulip.h index
> 0ed598dc7569c..10d7d8de93660 100644 ---
> a/drivers/net/ethernet/dec/tulip/tulip.h +++
> b/drivers/net/ethernet/dec/tulip/tulip.h @@ -250,7 +250,7 @@ enum
> t21143_csr6_bits { csr6_ttm = (1<<22),  /* Transmit Threshold Mode,
> set for 10baseT, 0 for 100BaseTX */ csr6_sf = (1<<21),   /* Store and
> forward. If set ignores TR bits */ csr6_hbd = (1<<19),  /* Heart beat
> disable. Disables SQE function in 10baseT */

If you are going to put "heartbeat" in the title of the patch, you may
want to fix "Heart beat" to match here as well. :-)


Kind regards,
     jer