[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOi1vP9AAQP7yqrXNRjvahy_t_Oz4+Z-CpT=uHscngC2OMWf5g@mail.gmail.com>
Date: Mon, 30 Jan 2023 18:47:44 +0100
From: Ilya Dryomov <idryomov@...il.com>
To: Christoph Hellwig <hch@....de>
Cc: Jens Axboe <axboe@...nel.dk>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Minchan Kim <minchan@...nel.org>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Keith Busch <kbusch@...nel.org>,
Sagi Grimberg <sagi@...mberg.me>,
Chaitanya Kulkarni <kch@...dia.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
David Howells <dhowells@...hat.com>,
Marc Dionne <marc.dionne@...istor.com>,
Xiubo Li <xiubli@...hat.com>, Steve French <sfrench@...ba.org>,
Trond Myklebust <trond.myklebust@...merspace.com>,
Anna Schumaker <anna@...nel.org>,
Mike Marshall <hubcap@...ibond.com>,
Andrew Morton <akpm@...ux-foundation.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Chuck Lever <chuck.lever@...cle.com>,
linux-block@...r.kernel.org, ceph-devel@...r.kernel.org,
virtualization@...ts.linux-foundation.org,
linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org,
target-devel@...r.kernel.org, kvm@...r.kernel.org,
netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
devel@...ts.orangefs.org, io-uring@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH 08/23] rbd: use bvec_set_page to initialize the copy up bvec
On Mon, Jan 30, 2023 at 10:22 AM Christoph Hellwig <hch@....de> wrote:
>
> Use the bvec_set_page helper to initialize the copy up bvec.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
> drivers/block/rbd.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 04453f4a319cb4..1faca7e07a4d52 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -3068,13 +3068,12 @@ static int setup_copyup_bvecs(struct rbd_obj_request *obj_req, u64 obj_overlap)
>
> for (i = 0; i < obj_req->copyup_bvec_count; i++) {
> unsigned int len = min(obj_overlap, (u64)PAGE_SIZE);
> + struct page *page = alloc_page(GFP_NOIO);
>
> - obj_req->copyup_bvecs[i].bv_page = alloc_page(GFP_NOIO);
> - if (!obj_req->copyup_bvecs[i].bv_page)
> + if (!page)
> return -ENOMEM;
>
> - obj_req->copyup_bvecs[i].bv_offset = 0;
> - obj_req->copyup_bvecs[i].bv_len = len;
> + bvec_set_page(&obj_req->copyup_bvecs[i], page, len, 0);
> obj_overlap -= len;
> }
>
> --
> 2.39.0
>
Reviewed-by: Ilya Dryomov <idryomov@...il.com>
Thanks,
Ilya
Powered by blists - more mailing lists